[SDK] fix avatar image detection on Node #7123
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant isImageUri
participant globalThis
Caller->>isImageUri: Call isImageUri(uri)
isImageUri->>isImageUri: Attempt network fetch of URI
alt Network error occurs
isImageUri->>globalThis: Check for Image object
alt Image exists
isImageUri->>isImageUri: Create Image instance, attempt to load URI
else Image does not exist
isImageUri-->>Caller: Return false
end
else No network error
isImageUri-->>Caller: Return result of fetch
end
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7123 +/- ##
==========================================
- Coverage 55.62% 55.61% -0.02%
==========================================
Files 902 902
Lines 58135 58162 +27
Branches 4087 4087
==========================================
+ Hits 32337 32344 +7
- Misses 25693 25713 +20
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>
Summary
Testing
pnpm test(fails: spawn anvil ENOENT)PR-Codex overview
This PR focuses on fixing the detection of avatar images in a Node.js environment by correcting the conditional check for the existence of the
Imageobject.Detailed summary
packages/thirdweb/src/utils/ens/avatar.tsfromif (Object.hasOwn(globalThis, "Image"))toif (!Object.hasOwn(globalThis, "Image"))to correctly handle image detection failures in Node.js.Summary by CodeRabbit