Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added web3 onboard page #5940

Merged
merged 1 commit into from
Jan 13, 2025
Merged

added web3 onboard page #5940

merged 1 commit into from
Jan 13, 2025

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Jan 13, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

CORE-694


PR-Codex overview

This PR introduces a new section for "Web3 Onboard" in the sidebar and adds corresponding documentation in page.mdx regarding the acquisition of Web3Onboard by thirdweb.

Detailed summary

  • Added a new entry for Web3 Onboard in the sidebar of sidebar.tsx.
  • Updated page.mdx with information about the acquisition of Web3Onboard by thirdweb, including links to documentation and support.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners January 13, 2025 17:03
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 5:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 13, 2025 5:13pm
thirdweb-www ⬜️ Skipped (Inspect) Jan 13, 2025 5:13pm
wallet-ui ⬜️ Skipped (Inspect) Jan 13, 2025 5:13pm

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: a693958

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 13, 2025
Copy link

graphite-app bot commented Jan 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (332536b) to head (a693958).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5940   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60903    60903           
  Branches     5128     5128           
=======================================
  Hits        33396    33396           
  Misses      26781    26781           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 332536b
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 3.7 s (+32.22% 🔺) 4.6 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 7.2 s (+16.38% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 285 ms (-4.32% 🔽) 397 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 180 ms (+73.54% 🔺) 190 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 1.5 s (+44.05% 🔺) 1.8 s

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 13, 2025
Copy link
Member

gregfromstl commented Jan 13, 2025

Merge activity

  • Jan 13, 12:08 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 13, 12:10 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 13, 12:14 PM EST: A user merged this pull request with the Graphite merge queue.

---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

CORE-694

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new section for "Web3 Onboard" in the sidebar and adds a corresponding documentation page in `page.mdx`, providing information about the acquisition of Web3Onboard by Blocknative and guidance for migration to thirdweb's SDK.

### Detailed summary
- Added a new entry for `Web3 Onboard` in the sidebar of `sidebar.tsx`.
- Created a new documentation page in `page.mdx` detailing the acquisition of Web3Onboard and migration instructions.
- Included links to Web3 Onboard's documentation and thirdweb's support site.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 13, 2025 17:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 13, 2025 17:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 13, 2025 17:11 Inactive
@graphite-app graphite-app bot merged commit a693958 into main Jan 13, 2025
31 checks passed
@graphite-app graphite-app bot deleted the web3-onboard-doc branch January 13, 2025 17:14
@vercel vercel bot temporarily deployed to Production – wallet-ui January 13, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www January 13, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 13, 2025 17:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants