Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit [DOCS]: Updated import. @thirdweb-dev/contracts and add _defaultAdmin #5848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nidz-the-fact
Copy link

@nidz-the-fact nidz-the-fact commented Dec 28, 2024

Edit: Updated import. @thirdweb-dev/contracts and add _defaultAdmin Latest required to AccountFactory.sol

Problem review

1. Importing @thirdweb-dev/contracts update

image

image


2. Add required _defaultAdmin

image

image


3. Deployments that require adding the -k secret key as well.

image

image

refer.
docs: https://portal.thirdweb.com/contracts/build/base-contracts/erc-4337/account-factory
smartcontract: https://github.com/thirdweb-dev/contracts/blob/main/contracts/prebuilts/account/non-upgradeable/AccountFactory.sol

Please check again. and consider as appropriate Thanks.


PR-Codex overview

This PR updates the import path for the AccountFactory contract and adds a new constructor parameter to the MyAccountFactory contract, ensuring it inherits correctly from the updated AccountFactory.

Detailed summary

  • Changed import path for AccountFactory from smart-wallet/non-upgradeable to prebuilts/account/non-upgradeable.
  • Added // SPDX-License-Identifier: GPL-3.0 and pragma solidity ^0.8.12; directives.
  • Updated the constructor of MyAccountFactory to include a new parameter: address _defaultAdmin.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

…atest required to AccountFactory.sol

Signed-off-by: Nidz The Fact <106298826+nidz-the-fact@users.noreply.github.com>
@nidz-the-fact nidz-the-fact requested review from jakubkrehel and a team as code owners December 28, 2024 09:30
Copy link

changeset-bot bot commented Dec 28, 2024

⚠️ No Changeset found

Latest commit: 34c4f64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Dec 28, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

vercel bot commented Dec 28, 2024

@nidz-the-fact is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant