Edit [DOCS]: Updated import. @thirdweb-dev/contracts and add _defaultAdmin #5848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Updated import. @thirdweb-dev/contracts and add _defaultAdmin Latest required to AccountFactory.sol
Problem review
1. Importing @thirdweb-dev/contracts update
❌
✅
2. Add required _defaultAdmin
❌
✅
3. Deployments that require adding the -k secret key as well.
❌
✅
refer.
docs: https://portal.thirdweb.com/contracts/build/base-contracts/erc-4337/account-factory
smartcontract: https://github.com/thirdweb-dev/contracts/blob/main/contracts/prebuilts/account/non-upgradeable/AccountFactory.sol
Please check again. and consider as appropriate Thanks.
PR-Codex overview
This PR updates the import path for the
AccountFactory
contract and adds a new constructor parameter to theMyAccountFactory
contract, ensuring it inherits correctly from the updatedAccountFactory
.Detailed summary
AccountFactory
fromsmart-wallet/non-upgradeable
toprebuilts/account/non-upgradeable
.// SPDX-License-Identifier: GPL-3.0
andpragma solidity ^0.8.12;
directives.MyAccountFactory
to include a new parameter:address _defaultAdmin
.