Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Chore: Update PR template #5846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 27, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the .github/pull_request_template.md to improve the clarity and structure of pull request submissions. It adds sections for issue tagging, reviewer notes, and testing instructions.

Detailed summary

  • Added a title section for concise change descriptions.
  • Introduced a section for issue tags if not copied from Linear.
  • Added a Notes for the reviewer section for important comments.
  • Included a How to test section for testing instructions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 27, 2024

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 7e2d1f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:25pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:25pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:25pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:25pm

Copy link

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important things to call out? Be sure to also clarify these in your comments.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompt "Anything important things" contains a grammatical error. Consider changing to "Any important things" to maintain correct English grammar.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (71eaf8f) to head (7e2d1f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5846   +/-   ##
=======================================
  Coverage   54.52%   54.52%           
=======================================
  Files        1105     1105           
  Lines       59332    59332           
  Branches     4921     4921           
=======================================
  Hits        32349    32349           
  Misses      26263    26263           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 71eaf8f
packages 52.01% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.07 KB (0%) 902 ms (0%) 1.1 s (+1.04% 🔺) 2 s
thirdweb (cjs) 110.94 KB (0%) 2.3 s (0%) 1.5 s (-9.39% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 217 ms (+235.4% 🔺) 329 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 95 ms (+265.26% 🔺) 105 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 211 ms (+50.33% 🔺) 594 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant