-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Feature: Adds eagerDeployment
on smart account creation
#5845
base: main
Are you sure you want to change the base?
[SDK] Feature: Adds eagerDeployment
on smart account creation
#5845
Conversation
🦋 Changeset detectedLatest commit: 61f9bbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5845 +/- ##
==========================================
+ Coverage 54.53% 54.56% +0.03%
==========================================
Files 1105 1105
Lines 59332 59409 +77
Branches 4924 4931 +7
==========================================
+ Hits 32354 32414 +60
- Misses 26258 26274 +16
- Partials 720 721 +1
*This pull request uses carry forward flags. Click here to find out more.
|
feat(sdk): add eagerDeployment option to smart wallets
61f9bbc
to
4a5b4b4
Compare
PR-Codex overview
This PR introduces the
eagerDeployment
option for smart accounts, allowing them to deploy before signing messages. This feature is designed for accounts needing EIP-1271 signatures, enhancing the signing process with improved deployment behavior.Detailed summary
eagerDeployment
option intypes.ts
.eagerDeployment
usage.smart-wallet.ts
to deploy accounts before signing messages ifeagerDeployment
is true.deployAndSignMessage
tosmartAccountSignMessage
).verifyEip1271Signature
.eagerDeployment
behavior insmart-wallet-integration-v07.test.ts
andsmart-wallet-integration.test.ts
.forceDeploySmartAccount
function to handle forced deployments.