-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onramp providers page to Pay overview #5836
base: main
Are you sure you want to change the base?
Conversation
|
You must have Developer access to commit code to thirdweb on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
icon: "thirdweb", | ||
}, | ||
title: "thirdweb Pay - Onramp Providers | thirdweb", | ||
description: ".", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata description
field contains only a period. Consider adding a descriptive summary of the onramp providers page that explains its purpose and content, which will improve SEO and provide better context in search results and link previews.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5836 +/- ##
=======================================
Coverage 54.12% 54.12%
=======================================
Files 1102 1102
Lines 59202 59202
Branches 4885 4885
=======================================
Hits 32045 32045
Misses 26433 26433
Partials 724 724
*This pull request uses carry forward flags. Click here to find out more. |
|
||
## Choosing a Preferred Provider | ||
|
||
It is possible to specify a preferred onramp provider by setting the `preferredProvider` parameter in the ConnectButton, PayEmbed, or Headless Integration. Go to [customizations](../pay/customization/connectbutton#preferredProvider) for more detail, or checkout the [API Reference for preferredProvider](https://portal.thirdweb.com/references/typescript/v5/GetBuyWithFiatQuoteParams). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relative path ../pay/customization/connectbutton#preferredProvider
needs to be updated to ../customization/connectbutton#preferred-provider
. The anchor portion of the URL should use kebab-case to match the auto-generated heading ID from the markdown processor.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
Added onramp page and preferredPartner information to customization pages
PR-Codex overview
This PR introduces enhancements related to preferred onramp providers in the payment integration documentation, along with updates to the sidebar navigation structure for better organization and access to features.
Detailed summary
## Preferred Provider
sections inpage.mdx
files forPayEmbed
andConnectButton
.preferredProvider
.metadata
inonramp-providers/page.mdx
.