Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Adds getAdminAccount to ecosystem wallets and cleans up smart account creation #5829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 23, 2024

Also Fixes TOOL-2833


PR-Codex overview

This PR introduces a new method, getAdminAccount, to the inAppWallet interface, enhancing support for account abstraction (AA) wallets. It also refactors existing wallet connection methods to streamline interactions with smart accounts.

Detailed summary

  • Added getAdminAccount method to inAppWallet interface.
  • Refactored wallet connection methods from connectSmartWallet to connectSmartAccount.
  • Updated tests to reflect new connection methods and account handling.
  • Enhanced logic to determine if an account is a smart account.
  • Improved error handling for personal account connections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners December 23, 2024 20:19
Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 3a9fa64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 8:34pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 8:34pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 8:34pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 8:34pm

Copy link

graphite-app bot commented Dec 23, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 790 ms (+59.44% 🔺) 1.7 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.3 s (-3.95% 🔽) 3.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 95 ms (-10.55% 🔽) 207 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 64 ms (+209.17% 🔺) 74 ms
thirdweb/react (minimal + tree-shaking) 19.11 KB (+0.02% 🔺) 383 ms (+0.02% 🔺) 246 ms (+18.6% 🔺) 628 ms

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 54.22%. Comparing base (1b103d7) to head (3a9fa64).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/smart/index.ts 82.35% 3 Missing ⚠️
...ackages/thirdweb/src/wallets/smart/smart-wallet.ts 76.92% 3 Missing ⚠️
...dweb/src/wallets/in-app/core/wallet/in-app-core.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5829      +/-   ##
==========================================
+ Coverage   54.11%   54.22%   +0.11%     
==========================================
  Files        1102     1102              
  Lines       59202    59215      +13     
  Branches     4885     4905      +20     
==========================================
+ Hits        32037    32111      +74     
+ Misses      26441    26379      -62     
- Partials      724      725       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1b103d7
packages 51.64% <82.97%> (+0.13%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/thirdweb/src/wallets/in-app/core/wallet/index.ts 73.03% <100.00%> (+66.65%) ⬆️
...dweb/src/wallets/in-app/core/wallet/in-app-core.ts 66.33% <86.66%> (+1.46%) ⬆️
packages/thirdweb/src/wallets/smart/index.ts 56.13% <82.35%> (-0.19%) ⬇️
...ackages/thirdweb/src/wallets/smart/smart-wallet.ts 78.64% <76.92%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 27, 2024
Copy link
Member Author

Merge activity

  • Dec 27, 4:20 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant