-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Refactor: More Viem to Ox migration #5790
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
22cb834
to
59faac0
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5790 +/- ##
==========================================
- Coverage 53.02% 53.02% -0.01%
==========================================
Files 1101 1101
Lines 59080 59122 +42
Branches 4810 4811 +1
==========================================
+ Hits 31328 31349 +21
- Misses 27034 27055 +21
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more.
|
@@ -103,9 +113,35 @@ | |||
accountFactory, | |||
}: VerifyContractWalletSignatureParams) { | |||
const messageHash = hashMessage(message); | |||
|
|||
const parsedSignature = (() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems a bit scary? maybe add tests for these sub cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few tests and removed signature object support (we can't support it until we re-add 1271 support. What's scary about it though? It's just parsing the input to the format we prefer
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on replacing instances of
maxUint256
imported fromviem
withmaxUint256
fromox/Solidity
, along with some adjustments in the workflow configuration and type definitions.Detailed summary
maxUint256
fromviem
toox/Solidity
in multiple files..github/workflows/auto-assign.yml
to includeready_for_review
anddraft
in thepull_request
triggers.ox
packages.