adds missing async to connect docs #5789
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
the
Portal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5789 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 1101 1101
Lines 59080 59080
Branches 4810 4809 -1
=======================================
Hits 31328 31328
Misses 27034 27034
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
joaquim-verges
approved these changes
Dec 18, 2024
gregfromstl
added
the
merge-queue
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
|
graphite-app
bot
removed
the
merge-queue
nischitpra
added
the
merge-queue
nischitpra
added a commit
that referenced
this pull request
Dec 18, 2024
## Problem solved
Adds missing `async` to connect callbacks in documentation
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `connect` function calls in multiple files to use an asynchronous arrow function instead of a regular function. This change enhances the handling of asynchronous operations within the `connect` function.
### Detailed summary
- Updated `connect` function calls in `page.mdx` files to use `async () =>` instead of `() =>`.
- Changes made in:
- `apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx`
- `apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx`
- `apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
nischitpra
force-pushed
the
np/minorfixes
branch
from
b4996be to
15ee155
Compare
nischitpra
added a commit
that referenced
this pull request
Dec 18, 2024
## Problem solved
Adds missing `async` to connect callbacks in documentation
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on modifying the `connect` function calls in various files to use an asynchronous callback, enhancing the handling of asynchronous operations during user authentication processes.
### Detailed summary
- Changed `await connect(() => {` to `await connect(async () => {` in multiple files:
- `apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx`
- `apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx`
- `apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
nischitpra
force-pushed
the
np/minorfixes
branch
from
15ee155 to
7b5dfc3
Compare
## Problem solved
Adds missing `async` to connect callbacks in documentation
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `connect` function calls in several files to use an asynchronous callback, enhancing the handling of post-login connections.
### Detailed summary
- Changed `await connect(() => {` to `await connect(async () => {` in multiple instances across different files:
- `apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx`
- `apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx`
- `apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx`
- `apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
nischitpra
force-pushed
the
np/minorfixes
branch
from
7b5dfc3 to
eb8e70c
Compare
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Adds missing
asyncto connect callbacks in documentationPR-Codex overview
This PR focuses on updating the
connectfunction calls to use an asynchronous callback pattern in varioushandleLoginfunctions across different files, enhancing the handling of asynchronous operations.Detailed summary
await connect(() => {...})toawait connect(async () => {...})in multiplehandleLoginfunctions:apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdxapps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdxapps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx