Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Feature: UI for crosschain modules #5399

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Nov 12, 2024

https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview


PR-Codex overview

This PR primarily focuses on enhancing the functionality and configuration of cross-chain interactions within the application. It includes updates to event handling, contract deployment, and UI components to support new features related to cross-chain capabilities.

Detailed summary

  • Updated TypeScript configuration URL in next-env.d.ts.
  • Modified namehash.ts to cast result as Uint8Array<ArrayBuffer>.
  • Added "Cross Chain" link in the sidebar of getContractPageSidebarLinks.ts.
  • Introduced showSuperchainBridgeFieldset function in modular-contract-default-modules-fieldset.tsx.
  • Added modifiedProxyDeployedEvent function in ProxyDeployed.ts with a TODO note.
  • Included nonce in the InstallPublishedModuleOptions interface.
  • Enhanced installPublishedModule function to handle nonce.
  • Introduced CROSS_CHAIN category in explore.ts with relevant contracts.
  • Updated deploy-via-autofactory.ts to use modifiedProxyDeployedEvent and handle cross-chain deployment.
  • Expanded deployContractfromDeployMetadata to include cross-chain handling.
  • Added cross-chain logic in cross-chain/page.tsx for fetching and displaying contract data.
  • Enhanced CustomContractForm for superchain interoperability and module installation.
  • Created a new DataTable component for managing cross-chain transfer functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 3cc27b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 10:09pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 10:09pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 10:09pm

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 57 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (5158def) to head (429d10c).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
.../src/contract/deployment/deploy-via-autofactory.ts 13.46% 45 Missing ⚠️
...rdweb/src/extensions/prebuilts/deploy-published.ts 66.66% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5399    +/-   ##
========================================
  Coverage   51.21%   51.22%            
========================================
  Files        1092     1092            
  Lines       57336    57454   +118     
  Branches     4674     4693    +19     
========================================
+ Hits        29364    29429    +65     
- Misses      27256    27309    +53     
  Partials      716      716            
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 828c198
packages 47.84% <40.62%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...xtensions/modules/common/installPublishedModule.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/utils/ens/namehash.ts 75.00% <100.00%> (+4.41%) ⬆️
...rdweb/src/extensions/prebuilts/deploy-published.ts 75.20% <66.66%> (-2.88%) ⬇️
.../src/contract/deployment/deploy-via-autofactory.ts 43.90% <13.46%> (-28.71%) ⬇️

... and 16 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 353 ms (-10.28% 🔽) 1.3 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 878 ms (+11.92% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 177 ms (+215.13% 🔺) 288 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 20 ms (+146.18% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 193 ms (+132.46% 🔺) 575 ms

@gregfromstl
Copy link
Member

@GWSzeto could you reference a linear ticket in the description

@gregfromstl gregfromstl changed the title UI for crosschain modules [Dashboard] Feature: UI for crosschain modules Nov 13, 2024
const { contract } = info;

if (contract.chain.id === localhost.id) {
return <div>asd</div>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the placeholder asd with a descriptive message that communicates the localhost limitation to users, such as Cross-chain deployment is not available on localhost networks

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

const events = await getContractEvents({
contract: twCloneFactoryContract,
events: [ProxyDeployedEvent],
blockRange: 123456n,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decide on what an appropriate way is to parse for this event

Copy link
Contributor

This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Dec 25, 2024
@github-actions github-actions bot closed this Dec 28, 2024
@GWSzeto GWSzeto reopened this Dec 29, 2024
@GWSzeto GWSzeto requested review from a team as code owners December 29, 2024 03:03
@github-actions github-actions bot removed the Stale label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants