Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Share Modal after applying freewallets coupon #5085

Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Oct 18, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new modal component, ShareFreeWalletsModal, for sharing free wallet offers. It integrates with the CouponCard component to display the modal when a specific coupon is applied.

Detailed summary

  • Added ShareFreeWalletsModal component with email sharing functionality.
  • Integrated ShareFreeWalletsModal into CouponSection to show modal on applying specific coupons.
  • Updated onCouponApplied callback in ApplyCouponCard to handle free wallet coupons.
  • Created Storybook stories for ShareFreeWalletsModal for both desktop and mobile views.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 6:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 19, 2024 6:40pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 19, 2024 6:40pm
wallet-ui ⬜️ Skipped (Inspect) Oct 19, 2024 6:40pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 23:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 23:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 23:31 Inactive
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: df128bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 18, 2024
@MananTank MananTank marked this pull request as ready for review October 18, 2024 23:31
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (f2d1085) to head (df128bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5085   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54729    54729           
  Branches     3956     3956           
=======================================
  Hits        24789    24789           
  Misses      29249    29249           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f2d1085
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank marked this pull request as draft October 18, 2024 23:33
Copy link
Contributor

github-actions bot commented Oct 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 781 ms (+29.78% 🔺) 1.7 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 1.4 s (-4.13% 🔽) 3.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 49 ms (+21.63% 🔺) 146 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 96 ms (+437.38% 🔺) 106 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 119 ms (+8.87% 🔺) 466 ms

@MananTank MananTank force-pushed the 10-19-open_share_modal_after_applying_freewallets_coupon branch from 41ffb94 to 8cfb040 Compare October 18, 2024 23:35
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 23:35 Inactive
@MananTank MananTank marked this pull request as ready for review October 18, 2024 23:35
@MananTank MananTank force-pushed the 10-19-open_share_modal_after_applying_freewallets_coupon branch from 8cfb040 to f60f21f Compare October 18, 2024 23:41
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 23:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 23:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 23:41 Inactive
@MananTank MananTank force-pushed the 10-19-open_share_modal_after_applying_freewallets_coupon branch from f60f21f to 4f5f29a Compare October 18, 2024 23:47
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 23:47 Inactive
Copy link

graphite-app bot commented Oct 19, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new modal component, `ShareFreeWalletsModal`, to facilitate sharing free wallet offers via social media or email. It also updates the `CouponCard` to handle coupon applications and trigger the modal.

### Detailed summary
- Added `ShareFreeWalletsModal` component for sharing options.
- Created Storybook stories for `ShareFreeWalletsModal` in `share-free-wallets-modal.stories.tsx`.
- Updated `ApplyCouponCard` to include an additional parameter for coupon application callback.
- Integrated lazy loading for `ShareFreeWalletsModal` in `CouponCard`.
- Implemented state management for modal visibility in `CouponSection`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-19-open_share_modal_after_applying_freewallets_coupon branch from 4f5f29a to df128bf Compare October 19, 2024 18:31
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 19, 2024 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 19, 2024 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 19, 2024 18:31 Inactive
@graphite-app graphite-app bot merged commit df128bf into main Oct 19, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-19-open_share_modal_after_applying_freewallets_coupon branch October 19, 2024 18:40
@vercel vercel bot temporarily deployed to Production – docs-v2 October 19, 2024 18:40 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 19, 2024 18:40 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 19, 2024 18:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants