-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noUncheckedIndexedAccess: true in dashboard tsconfig and fix all issues #5084
Add noUncheckedIndexedAccess: true in dashboard tsconfig and fix all issues #5084
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on Graphite |
8efe7af
to
d027088
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5084 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1059 1059
Lines 54729 54729
Branches 3956 3956
=======================================
Hits 24791 24791
Misses 29247 29247
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
d027088
to
da7a821
Compare
da7a821
to
36350b7
Compare
Merge activity
|
…issues (#5084) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces various enhancements and bug fixes across multiple files, focusing on improving type safety, handling undefined values, and refining conditions to prevent errors. It also updates the handling of cookies, contract metadata, and native token definitions. ### Detailed summary - Added `"noUncheckedIndexedAccess": true` in `tsconfig.json`. - Updated cookie retrieval to check for `_val` in `SyncStoreToCookies.tsx`. - Modified ecosystem redirection condition in `EcosystemLandingPage.tsx`. - Added checks for undefined chains in `allChains.ts`. - Improved handling of optional values in various components. - Enhanced error handling for uploaded files in `IconUpload.tsx`. - Refactored native token definitions for better clarity and maintainability. - Checked for existence of items before accessing properties in several components. - Ensured consistent handling of optional chaining to avoid runtime errors. - Updated metadata handling in various contract-related components. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
36350b7
to
5da500e
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces several code improvements, including enhanced null checks, type safety adjustments, and optimizations in various components and hooks. It aims to improve code reliability and prevent potential runtime errors.
Detailed summary
noUncheckedIndexedAccess
intsconfig.json
.SyncStoreToCookies.tsx
.EcosystemLandingPage.tsx
.allChains.ts
.useDashboardContractMetadata.tsx
.distribute-button.tsx
.connect-frames.ts
.tokenUri.ts
.image-upload.tsx
.WalletDistributionChartCard.tsx
.