Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chain page Open graph metadata + image #5081

Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Oct 18, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the Open Graph metadata and image properties for the chain page in the dashboard application.

Detailed summary

  • In layout.tsx, added openGraph object containing title and description properties.
  • In opengraph-image.tsx, added objectFit: "contain" to the image styling for better presentation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:10pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 18, 2024 5:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 18, 2024 5:10pm
wallet-ui ⬜️ Skipped (Inspect) Oct 18, 2024 5:10pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 16:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 16:35 Inactive
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: a04cda1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 16:35 Inactive
Copy link

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 18, 2024 16:35
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 18, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (67a363f) to head (a04cda1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5081   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54729    54729           
  Branches     3957     3957           
=======================================
  Hits        24791    24791           
  Misses      29247    29247           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 67a363f
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 352 ms (+2.15% 🔺) 1.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 1.1 s (+30.74% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 77 ms (-13.12% 🔽) 174 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 118 ms (+1674.3% 🔺) 128 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 165 ms (+164.71% 🔺) 512 ms

@MananTank MananTank changed the title Improved chain page Open graph metadata + image Improve chain page Open graph metadata + image Oct 18, 2024
Copy link

graphite-app bot commented Oct 18, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the Open Graph metadata and improving the layout of the `chainPage` component in the dashboard application.

### Detailed summary
- In `layout.tsx`, added an `openGraph` object containing `title` and `description`.
- In `opengraph-image.tsx`, added the `objectFit` property with the value `"contain"` for image styling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-18-improved_chain_page_open_graph_metadata_image branch from b5e3447 to a04cda1 Compare October 18, 2024 17:00
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 17:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 17:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 17:00 Inactive
@graphite-app graphite-app bot merged commit a04cda1 into main Oct 18, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-18-improved_chain_page_open_graph_metadata_image branch October 18, 2024 17:11
@vercel vercel bot temporarily deployed to Production – docs-v2 October 18, 2024 17:11 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 18, 2024 17:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 18, 2024 17:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants