Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Contract page components to app router folder (no code change) #5071

Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Oct 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR primarily focuses on refactoring the structure of the dashboard application by reorganizing component imports and paths, enhancing modularity, and improving clarity in the codebase.

Detailed summary

  • Updated import paths for various components to use local references instead of relative paths.
  • Renamed several pages and components to reflect their new locations.
  • Consolidated similar functionalities under new components for better organization.
  • Ensured consistent usage of ThirdwebContract across components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 8:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 17, 2024 8:32pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 17, 2024 8:32pm
wallet-ui ⬜️ Skipped (Inspect) Oct 17, 2024 8:32pm

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 7855c3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 19:56 Inactive
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 17, 2024
@MananTank MananTank marked this pull request as ready for review October 17, 2024 19:57
@MananTank MananTank changed the title Move Contract page components to app router folder Move Contract page components to app router folder ( no code change) Oct 17, 2024
@MananTank MananTank changed the title Move Contract page components to app router folder ( no code change) Move Contract page components to app router folder (no code change) Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 418 ms (+35.08% 🔺) 1.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 767 ms (-15.69% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 23 ms (+40.89% 🔺) 120 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 15 ms (+75.34% 🔺) 25 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 73 ms (-12.23% 🔽) 421 ms

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (6597cb6) to head (7855c3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5071   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6597cb6
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link

graphite-app bot commented Oct 17, 2024

Merge activity

…5071)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on restructuring the file organization and imports within the `dashboard` application. It moves components to a more cohesive structure, enhancing maintainability and clarity.

### Detailed summary
- Updated imports to use relative paths instead of absolute paths.
- Renamed several component files for consistency.
- Moved `CancelDirectListing` and `CancelEnglishAuction` to a new structure under `components`.
- Adjusted imports in various `page.tsx` files to reflect new component paths.
- Consolidated marketplace-related components under a unified structure.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-18-move_contract_page_components_to_app_router_folder branch from a9e0a6d to 7855c3e Compare October 17, 2024 20:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 20:22 Inactive
@graphite-app graphite-app bot merged commit 7855c3e into main Oct 17, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-18-move_contract_page_components_to_app_router_folder branch October 17, 2024 20:32
@vercel vercel bot temporarily deployed to Production – docs-v2 October 17, 2024 20:32 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 17, 2024 20:32 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 17, 2024 20:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants