Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small typo #5070

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: small typo #5070

merged 1 commit into from
Oct 17, 2024

Conversation

GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Oct 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on correcting the links in the page.mdx file related to modular contracts in the portal documentation.

Detailed summary

  • Updated the link for Create Core Contract from create-core-contact to create-core-contract.
  • Updated the link for Create Module Contract from create-module-contact to create-module-contract.
  • Removed the link for Deploy Modular Contract.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:30pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 17, 2024 7:30pm
thirdweb-www ⬜️ Skipped (Inspect) Oct 17, 2024 7:30pm
wallet-ui ⬜️ Skipped (Inspect) Oct 17, 2024 7:30pm

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 6597cb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 17, 2024
@GWSzeto GWSzeto added merge-queue Adds the pull request to Graphite's merge queue. and removed Portal Involves changes to the Portal (docs) codebase. labels Oct 17, 2024
Copy link
Contributor Author

GWSzeto commented Oct 17, 2024

Merge activity

  • Oct 17, 2:51 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 17, 2:56 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 17, 3:21 PM EDT: A user merged this pull request with the Graphite merge queue.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (fbd9853) to head (6597cb6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5070   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fbd9853
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 192 ms (+77.26% 🔺) 1.1 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 366 ms (+0.36% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 38 ms (+590.95% 🔺) 135 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 23 ms (+549.13% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 56 ms (+80.46% 🔺) 403 ms

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on correcting the links in the `page.mdx` file related to modular contracts in the portal documentation.

### Detailed summary
- Fixed the link for `Create Core Contract` from `create-core-contact` to `create-core-contract`.
- Fixed the link for `Create Module Contract` from `create-module-contact` to `create-module-contract`.
- Removed the link for `Deploy Modular Contract`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 19:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 17, 2024 19:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 19:19 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 17, 2024
@graphite-app graphite-app bot merged commit 6597cb6 into main Oct 17, 2024
27 of 28 checks passed
@graphite-app graphite-app bot deleted the fix-mc-getting-started branch October 17, 2024 19:21
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 17, 2024 19:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 17, 2024 19:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 17, 2024 19:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants