Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: GitHub Auth #5062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SDK] Feature: GitHub Auth #5062

wants to merge 1 commit into from

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Oct 17, 2024

PR-Codex overview

This PR introduces GitHub authentication support across various components of the application, enhancing the social login options for users.

Detailed summary

  • Added GitHub to authentication options in types.ts.
  • Included GitHub in the social login forms and icons.
  • Updated the InAppWebConnector to handle GitHub authentication.
  • Defined GITHUB_ICON SVG for branding.
  • Integrated githubIconUri for wallet icons.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Oct 17, 2024

CNCT-2093 GitHub Auth

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:06am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:06am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:06am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:06am

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 5527b90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 404 ms (+19.92% 🔺) 1.3 s
thirdweb (cjs) 102.53 KB (0%) 2.1 s (0%) 761 ms (+8.48% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 37 ms (+4.16% 🔺) 134 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 12 ms (+66.56% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 81 ms (+6.33% 🔺) 428 ms

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.27%. Comparing base (63037f1) to head (5527b90).

Files with missing lines Patch % Lines
...ckages/thirdweb/src/react/core/utils/walletIcon.ts 60.00% 2 Missing ⚠️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.00% 2 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 1 Missing ⚠️
...irdweb/src/react/web/wallets/shared/oauthSignIn.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5062      +/-   ##
==========================================
- Coverage   45.29%   45.27%   -0.03%     
==========================================
  Files        1059     1060       +1     
  Lines       54728    54766      +38     
  Branches     3954     3954              
==========================================
+ Hits        24791    24795       +4     
- Misses      29246    29280      +34     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 63037f1
packages 40.21% <40.00%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/types.ts 100.00% <100.00%> (ø)
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 7.16% <0.00%> (-0.02%) ⬇️
...irdweb/src/react/web/wallets/shared/oauthSignIn.ts 4.16% <0.00%> (-0.06%) ⬇️
...ckages/thirdweb/src/react/core/utils/walletIcon.ts 57.83% <60.00%> (+0.13%) ⬆️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.27% <0.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants