Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallets] Add plugin to transform flow types to fix RN FlatList bug #1425

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

iketw
Copy link
Contributor

@iketw iketw commented Aug 1, 2023

RN > 0.72.0 has a bug with removing private methods specifically in RN's FlatList

"@babel/plugin-transform-private-methods",
"@babel/plugin-proposal-class-properties"

facebook/react-native#36828 (comment)
facebook/react-native#34783

Fix:

  • Add the babel plugin-transform-flow-strip-types plugin for flow (which is what RN uses)

@iketw iketw requested a review from a team as a code owner August 1, 2023 22:58
@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

🦋 Changeset detected

Latest commit: 6922625

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iketw iketw enabled auto-merge August 1, 2023 23:01
@iketw iketw added this pull request to the merge queue Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0af916e) 70.55% compared to head (6922625) 70.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1425   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files         320      320           
  Lines       11139    11139           
  Branches     1458     1458           
=======================================
  Hits         7859     7859           
  Misses       2670     2670           
  Partials      610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit b0ec1d8 Aug 1, 2023
8 checks passed
@iketw iketw deleted the ike/private branch August 1, 2023 23:17
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant