-
Notifications
You must be signed in to change notification settings - Fork 19
Refactor data insertion logic #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iuwqyir
merged 1 commit into
main
from
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
Oct 10, 2024
Merged
Refactor data insertion logic #89
iuwqyir
merged 1 commit into
main
from
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
Oct 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
d0e0f6f
to
4773497
Compare
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
approved these changes
Oct 7, 2024
5b416ef
to
8663df7
Compare
d06c5d1
to
d0961cb
Compare
d0961cb
to
b11b079
Compare
AmineAfia
approved these changes
Oct 7, 2024
8663df7
to
01aba8e
Compare
b11b079
to
dd391a7
Compare
This was referenced Oct 8, 2024
dd391a7
to
ccac684
Compare
01aba8e
to
49fe94d
Compare
ccac684
to
6ead9a7
Compare
6ead9a7
to
0f12a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored data insertion process to allow the storage decide how to handle batched data.
E.g sql databases can use transactions and concurrency whereas memory storage can do everything sequentially
What changed?
InsertDataForBlocks
method in theIMainStorage
interface.InsertDataForBlocks
in both ClickHouseConnector and MemoryConnector.InsertDataForBlocks
method instead ofsaveDataToMainStorage
.