Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image tagging in release workflow #107

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

iuwqyir
Copy link
Collaborator

@iuwqyir iuwqyir commented Oct 17, 2024

TL;DR

Updated Docker image tagging strategy in the release workflow.

What changed?

  • Modified the tagging logic for the Docker image in the docker-release.yml workflow.
  • Changed the condition for the latest tag to be applied only when the workflow is manually triggered.
  • Added a new tag using semantic versioning pattern.

How to test?

  1. Manually trigger the workflow to verify the latest tag is applied.
  2. Create a new release with a semantic version (e.g., v1.2.3) to confirm the new versioning tag is correctly applied.
  3. Check the Docker registry to ensure the images are tagged as expected.

Why make this change?

This change provides more control over when the latest tag is applied and introduces semantic versioning for better version management of Docker images. It allows for more precise tracking of image versions and ensures the latest tag is only updated when explicitly desired through manual workflow triggers.

Copy link
Collaborator Author

iuwqyir commented Oct 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

@iuwqyir iuwqyir changed the title another fix for docker release version Update Docker image tagging in release workflow Oct 17, 2024
@iuwqyir iuwqyir marked this pull request as ready for review October 17, 2024 14:20
@iuwqyir iuwqyir merged commit b0a4ef9 into main Oct 17, 2024
5 checks passed
@iuwqyir iuwqyir deleted the 10-17-another_fix_for_docker_release_version branch October 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant