Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 31, 2024

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR enhances the writeToContract function by adding support for parsing ABI parameters and includes new tests for writing to a contract with untyped arguments.

Detailed summary

  • Added parseAbiParams to handle method input parameters in writeToContract.
  • Changed params assignment to use parsed parameters from method.inputs.
  • Introduced a new test for writing to a contract with untyped arguments.
  • Updated existing tests to ensure compatibility with new functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joaquim-verges joaquim-verges marked this pull request as ready for review October 31, 2024 19:56
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges force-pushed the Add_support_for_untyped_contract_args_in_/write branch from c327871 to c85d762 Compare October 31, 2024 20:07
@joaquim-verges joaquim-verges merged commit 05bb234 into main Oct 31, 2024
6 checks passed
@joaquim-verges joaquim-verges deleted the Add_support_for_untyped_contract_args_in_/write branch October 31, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants