feat: Add mTLS and custom HMAC support to webhooks #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arcoraven
changed the title
arcoraven
commented
Oct 31, 2024
| vi.clearAllMocks(); | ||
| }); | ||
|
|
||
| it("should return the chainId from chainOverrides if it exists by slug", async () => { |
Contributor
Author
There was a problem hiding this comment.
Unrelated but fixing some broken unit tests
arcoraven
commented
Oct 31, 2024
| const path = process.env.NODE_ENV === "test" ? ".env.test" : ".env"; | ||
| dotenv.config({ path }); | ||
|
|
||
| export const JsonSchema = z.string().refine( |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on adding mTLS (Mutual TLS) support for secure communication, updating the configuration management, and enhancing webhook functionalities. It introduces new fields for storing encrypted certificates and keys, along with related validation and request handling improvements.
Detailed summary
mtlsCertificateEncryptedandmtlsPrivateKeyEncryptedcolumns to theconfigurationtable.updateConfigurationfunction to usePrisma.ConfigurationUpdateInput.updateAuthConfiguration.generateSecretHmac256for generating HMAC signatures for webhook requests.sendWebhookRequestto utilize mTLS if configured.generateRequestHeadersto include HMAC authorization..env.testfor AWS and GCP configurations.testWebhookRoutefor testing webhook functionality.crypto.tsfor improved decryption handling.