Skip to content

Use invariant culture for AWS date formatting #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Use invariant culture for AWS date formatting #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Authentication/AWS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ private static async Task<string> PostAwsRequestWithDateOverride(

var dateTimeNow = dateOverride ?? DateTime.UtcNow;
var amzDateFormat = "yyyyMMddTHHmmssZ";
var amzDate = dateTimeNow.ToString(amzDateFormat);
var dateStamp = dateTimeNow.ToString("yyyyMMdd");
var amzDate = dateTimeNow.ToString(amzDateFormat, System.Globalization.CultureInfo.InvariantCulture);
var dateStamp = dateTimeNow.ToString("yyyyMMdd", System.Globalization.CultureInfo.InvariantCulture);

var canonicalHeaders = $"host:{new Uri(endpoint).Host}\n" + $"x-amz-date:{amzDate}\n";
var signedHeaders = "host;x-amz-date";
Expand Down Expand Up @@ -181,7 +181,7 @@ private static async Task<string> PostAwsRequestWithDateOverride(
if (idx > -1)
{
var parsedTimeString = responseContent.Substring(idx + 1, amzDate.Length);
var serverTime = DateTime.ParseExact(parsedTimeString, amzDateFormat, System.Globalization.CultureInfo.InvariantCulture).ToUniversalTime();
var serverTime = DateTime.ParseExact(parsedTimeString, amzDateFormat, System.Globalization.CultureInfo.InvariantCulture, System.Globalization.DateTimeStyles.AssumeUniversal);

return await PostAwsRequestWithDateOverride(
credentials,
Expand Down
Loading