Opensea operator filterer + toggle #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| emit OperatorRestriction(_restriction); | ||
| } | ||
|
|
||
| function _canSetOperatorRestriction() internal virtual returns (bool) {} |
There was a problem hiding this comment.
you're not calling this anywhere
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+328
to
+369
| function _safeMint( | ||
| address to, | ||
| uint256 quantity, | ||
| bytes memory _data | ||
| ) internal { | ||
| uint256 startTokenId = _currentIndex; | ||
| if (to == address(0)) revert MintToZeroAddress(); | ||
| if (quantity == 0) revert MintZeroQuantity(); | ||
|
|
||
| _beforeTokenTransfers(address(0), to, startTokenId, quantity); | ||
|
|
||
| // Overflows are incredibly unrealistic. | ||
| // balance or numberMinted overflow if current value of either + quantity > 1.8e19 (2**64) - 1 | ||
| // updatedIndex overflows if _currentIndex + quantity > 1.2e77 (2**256) - 1 | ||
| unchecked { | ||
| _addressData[to].balance += uint64(quantity); | ||
| _addressData[to].numberMinted += uint64(quantity); | ||
|
|
||
| _ownerships[startTokenId].addr = to; | ||
| _ownerships[startTokenId].startTimestamp = uint64(block.timestamp); | ||
|
|
||
| uint256 updatedIndex = startTokenId; | ||
| uint256 end = updatedIndex + quantity; | ||
|
|
||
| if (to.isContract()) { | ||
| do { | ||
| emit Transfer(address(0), to, updatedIndex); | ||
| if (!_checkContractOnERC721Received(address(0), to, updatedIndex++, _data)) { | ||
| revert TransferToNonERC721ReceiverImplementer(); | ||
| } | ||
| } while (updatedIndex < end); | ||
| // Reentrancy protection | ||
| if (_currentIndex != startTokenId) revert(); | ||
| } else { | ||
| do { | ||
| emit Transfer(address(0), to, updatedIndex++); | ||
| } while (updatedIndex < end); | ||
| } | ||
| _currentIndex = updatedIndex; | ||
| } | ||
| _afterTokenTransfers(address(0), to, startTokenId, quantity); | ||
| } |
Check warning
Code scanning / Slither
Reentrancy vulnerabilities
Comment on lines
+565
to
+584
| function _checkContractOnERC721Received( | ||
| address from, | ||
| address to, | ||
| uint256 tokenId, | ||
| bytes memory _data | ||
| ) private returns (bool) { | ||
| try IERC721ReceiverUpgradeable(to).onERC721Received(_msgSender(), from, tokenId, _data) returns ( | ||
| bytes4 retval | ||
| ) { | ||
| return retval == IERC721ReceiverUpgradeable(to).onERC721Received.selector; | ||
| } catch (bytes memory reason) { | ||
| if (reason.length == 0) { | ||
| revert TransferToNonERC721ReceiverImplementer(); | ||
| } else { | ||
| assembly { | ||
| revert(add(32, reason), mload(reason)) | ||
| } | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Unused return
| bytes memory _data | ||
| ) private returns (bool) { | ||
| try IERC721ReceiverUpgradeable(to).onERC721Received(_msgSender(), from, tokenId, _data) returns ( | ||
| bytes4 retval |
Check notice
Code scanning / Slither
Pre-declaration usage of local variables
| bytes4 retval | ||
| ) { | ||
| return retval == IERC721ReceiverUpgradeable(to).onERC721Received.selector; | ||
| } catch (bytes memory reason) { |
Check notice
Code scanning / Slither
Pre-declaration usage of local variables
| bytes4 retval | ||
| ) { | ||
| return retval == IERC721ReceiverUpgradeable(to).onERC721Received.selector; | ||
| } catch (bytes memory reason) { |
Check notice
Code scanning / Slither
Pre-declaration usage of local variables
Comment on lines
+565
to
+584
| function _checkContractOnERC721Received( | ||
| address from, | ||
| address to, | ||
| uint256 tokenId, | ||
| bytes memory _data | ||
| ) private returns (bool) { | ||
| try IERC721ReceiverUpgradeable(to).onERC721Received(_msgSender(), from, tokenId, _data) returns ( | ||
| bytes4 retval | ||
| ) { | ||
| return retval == IERC721ReceiverUpgradeable(to).onERC721Received.selector; | ||
| } catch (bytes memory reason) { | ||
| if (reason.length == 0) { | ||
| revert TransferToNonERC721ReceiverImplementer(); | ||
| } else { | ||
| assembly { | ||
| revert(add(32, reason), mload(reason)) | ||
| } | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
| * variables without shifting down storage in the inheritance chain. | ||
| * See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps | ||
| */ | ||
| uint256[42] private __gap; |
Check warning
Code scanning / Slither
Unused state variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension/DefaultOperatorFiltererandextension/OperatorFiltererto apply operator filter restrictions based on a toggle.extension/OperatorFilterTogglewhich is the aforementioned toggle.TokenERC721,TokenERC1155,DropERC721andDropERC1155to support OpenSea operator filter with a toggle.