Skip to content

fix: add virtual so that function can be overriden #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2022
Merged

fix: add virtual so that function can be overriden #289

merged 2 commits into from
Dec 11, 2022

Conversation

atharvadeosthale
Copy link
Contributor

currently receiving error that function must be virtual to override, did some digging and discovered that _mintRewards() should have been virtual instead

@kumaryash90 kumaryash90 merged commit 3014c2c into thirdweb-dev:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants