MultichainRegistry: new code pattern #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
19
to
42
| function add( | ||
| address _deployer, | ||
| address _deployment, | ||
| uint256 _chainId, | ||
| string memory metadataUri | ||
| ) external { | ||
| require( | ||
| PermissionsEnumerable(address(this)).hasRole(OPERATOR_ROLE, _msgSender()) || _deployer == _msgSender(), | ||
| "not operator or deployer." | ||
| ); | ||
|
|
||
| TWMultichainRegistryStorage.Data storage data = TWMultichainRegistryStorage.multichainRegistryStorage(); | ||
|
|
||
| bool added = data.deployments[_deployer][_chainId].add(_deployment); | ||
| require(added, "failed to add"); | ||
|
|
||
| data.chainIds.add(_chainId); | ||
|
|
||
| if (bytes(metadataUri).length > 0) { | ||
| data.addressToMetadataUri[_chainId][_deployment] = metadataUri; | ||
| } | ||
|
|
||
| emit Added(_deployer, _deployment, _chainId, metadataUri); | ||
| } |
Check warning
Code scanning / Slither
Unused return
Comment on lines
+19
to
+24
| function multichainRegistryStorage() internal pure returns (Data storage multichainRegistryData) { | ||
| bytes32 position = MULTICHAIN_REGISTRY_STORAGE_POSITION; | ||
| assembly { | ||
| multichainRegistryData.slot := position | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+14
to
+19
| function permissionsStorage() internal pure returns (Data storage permissionsData) { | ||
| bytes32 position = PERMISSIONS_STORAGE_POSITION; | ||
| assembly { | ||
| permissionsData.slot := position | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+11
to
+16
| function erc2771ContextStorage() internal pure returns (Data storage erc2771ContextData) { | ||
| bytes32 position = ERC2771_CONTEXT_STORAGE_POSITION; | ||
| assembly { | ||
| erc2771ContextData.slot := position | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+27
to
+32
| function permissionsEnumerableStorage() internal pure returns (Data storage permissionsEnumerableData) { | ||
| bytes32 position = PERMISSIONS_ENUMERABLE_STORAGE_POSITION; | ||
| assembly { | ||
| permissionsEnumerableData.slot := position | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+14
to
+23
| function _msgSender() public view virtual returns (address sender) { | ||
| if (IERC2771Context(address(this)).isTrustedForwarder(msg.sender)) { | ||
| // The assembly code is more direct than the Solidity version using `abi.decode`. | ||
| assembly { | ||
| sender := shr(96, calldataload(sub(calldatasize(), 20))) | ||
| } | ||
| } else { | ||
| return msg.sender; | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
| function getRoleMember(bytes32 role, uint256 index) external view override returns (address member) { | ||
| PermissionsEnumerableStorage.Data storage data = PermissionsEnumerableStorage.permissionsEnumerableStorage(); | ||
| uint256 currentIndex = data.roleMembers[role].index; | ||
| uint256 check; |
Check warning
Code scanning / Slither
Uninitialized local variables
Comment on lines
+23
to
+32
| function _msgSender() internal view virtual returns (address sender) { | ||
| if (isTrustedForwarder(msg.sender)) { | ||
| // The assembly code is more direct than the Solidity version using `abi.decode`. | ||
| assembly { | ||
| sender := shr(96, calldataload(sub(calldatasize(), 20))) | ||
| } | ||
| } else { | ||
| return msg.sender; | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+59
to
+68
| function _msgSender() internal view override(ERC2771ContextLogic, PermissionsLogic) returns (address sender) { | ||
| if (isTrustedForwarder(msg.sender)) { | ||
| // The assembly code is more direct than the Solidity version using `abi.decode`. | ||
| assembly { | ||
| sender := shr(96, calldataload(sub(calldatasize(), 20))) | ||
| } | ||
| } else { | ||
| return msg.sender; | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.