Skip to content

Pack refactor downsized #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 31, 2022
Merged

Pack refactor downsized #229

merged 24 commits into from
Aug 31, 2022

Conversation

kumaryash90
Copy link
Member

No description provided.

kumaryash90 and others added 18 commits July 15, 2022 01:18
@nkrishang
Copy link
Contributor

When initializing transferRole, etc. in the initialize function, use memory variables in internal function calls (e.g. _setupRole) instead of the actual state variables (transferRole, etc.).

If the contract exceeds the size limit due to this, disregard this suggestion.

@nkrishang
Copy link
Contributor

Check whether adding ERC1155Receiver is necessary in the top level supportsInterface function.

@nkrishang
Copy link
Contributor

In addPackContents, add the following check: require(balanceOf[recipient][packId] > 0)

@kumaryash90
Copy link
Member Author

applied the changes @nkrishang

@kumaryash90 kumaryash90 merged commit 9247a05 into main Aug 31, 2022
@nkrishang nkrishang deleted the pack-refactor-downsized branch September 23, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeloo jakeloo Awaiting requested review from jakeloo

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@nkrishang nkrishang Awaiting requested review from nkrishang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaryash90 @nkrishang @jakeloo