Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thirdweb-dev/contracts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3d04ee7
Choose a base ref
...
head repository: thirdweb-dev/contracts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4709d1e
Choose a head ref
  • 3 commits
  • 46 files changed
  • 2 contributors

Commits on Dec 12, 2022

  1. forge update

    nkrishang committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2b3f5e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Staking updates (#298)

    * more efficient way of storing state for Staking contracts
    
    * [M-1] Block gas limit can be exceeded during setTimeUnit() and setRewardsPerUnit() when staker count grows
    
    * [C-1] Contract admins can lock staked tokens in the contract
    
    * [M-1] revised fix for Staking1155
    
    * [H-1] TokenStake.sol rewards can be over- or under-awarded when the staking and reward tokens have different decimals
    
    * [M-2] ERC721 and ERC1155 tokens safe-transferred directly to contract will be locked and unrecoverable
    
    * [C-1] revised fix for large rewardsPerUnitTime
    
    * [L-1] Incorrect ERC165 implementation for NFTStake and EditionStake
    
    * [Q-2] Normalize support for ERC2771 trusted forwarder
    
    * [Q-3] Reentrancy init called twice
    
    * [Q-5] unitTime and rewardsPerUnitTime setter functions don’t check for new input data
    
    * [Q-6] getStakeInfo should be marked as external
    
    * [G-1] Halt array iteration after staker removed during withdraw()
    
    * [G-2] Loop reading from storage array length
    
    * [Q-7] Missing reward balance information
    
    * [M-3] TokenStake.sol: Double entry-point ERC20 tokens could be drained from the staking contract
    
    * [H-2] TokenStake.sol: Tokens with a tax on transfer will account for inaccurate amounts
    
    * virtual functions for bases
    
    * docs
    
    * v3.2.9
    
    * handle native token
    
    * rename to stakingToken
    
    * remove beta tag
    
    * interfaces
    
    Co-authored-by: Krishang <krishang@thirdweb.com>
    kumaryash90 and nkrishang authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6179287 View commit details
    Browse the repository at this point in the history
  2. Plugin updates (#297)

    * plugin updates
    
    * fix issue, code cleanup
    kumaryash90 authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    4709d1e View commit details
    Browse the repository at this point in the history
Loading