Skip to content

Add spender address, remove direct transfer flag #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions src/UniversalBridgeV1.sol
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ contract UniversalBridgeV1 is Initializable, UUPSUpgradeable, Ownable, Reentranc
address tokenAddress,
uint256 tokenAmount,
address payable forwardAddress,
address payable spenderAddress,
address payable developerFeeRecipient,
uint256 developerFeeBps,
bool directTransfer,
bytes calldata callData,
bytes calldata extraData
) external payable nonReentrant onlyProxy {
Expand All @@ -161,40 +161,33 @@ contract UniversalBridgeV1 is Initializable, UUPSUpgradeable, Ownable, Reentranc
if (tokenAmount == 0) {
revert UniversalBridgeInvalidAmount(tokenAmount);
}
uint256 sendValue = msg.value; // includes bridge fee etc. (if any)

// mark the pay request as processed
_universalBridgeStorage().processed[transactionId] = true;

uint256 sendValue = msg.value; // includes bridge fee etc. (if any)

// distribute fees
uint256 totalFeeAmount = _distributeFees(tokenAddress, tokenAmount, developerFeeRecipient, developerFeeBps);

// determine native value to send
if (_isNativeToken(tokenAddress)) {
sendValue = msg.value - totalFeeAmount;

if (sendValue < tokenAmount) {
revert UniversalBridgeMismatchedValue(tokenAmount, sendValue);
}
}

if (directTransfer) {
if (_isNativeToken(tokenAddress)) {
_call(forwardAddress, sendValue, "");
} else {
if (msg.value != 0) {
revert UniversalBridgeMsgValueNotZero();
}

SafeTransferLib.safeTransferFrom(tokenAddress, msg.sender, forwardAddress, tokenAmount);
_call(forwardAddress, sendValue, callData); // calldata empty for direct transfer
} else if (callData.length == 0) {
if (msg.value != 0) {
revert UniversalBridgeMsgValueNotZero();
}
SafeTransferLib.safeTransferFrom(tokenAddress, msg.sender, forwardAddress, tokenAmount);
} else {
if (!_isNativeToken(tokenAddress)) {
// pull user funds
SafeTransferLib.safeTransferFrom(tokenAddress, msg.sender, address(this), tokenAmount);
SafeTransferLib.safeApprove(tokenAddress, forwardAddress, tokenAmount);
}
// pull user funds
SafeTransferLib.safeTransferFrom(tokenAddress, msg.sender, address(this), tokenAmount);

// approve to spender address and call forward address -- both will be same in most cases
SafeTransferLib.safeApprove(tokenAddress, spenderAddress, tokenAmount);
_call(forwardAddress, sendValue, callData);
}

Expand Down
Loading