Feature: Automated Expo PR Builds #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paribaker
commented
Aug 16, 2024
| "developmentClient": true, | ||
| "distribution": "internal", | ||
| "channel": $expo_channel, |
There was a problem hiding this comment.
One thought I had was, if we remove the channel here will we be able to use the statically defined config instead of dynamically creating a new entry?
The reason we are adding this entry is so that there will be a unique build for this PR that does not affect other PR's. However since this one is built on the fly in order to test it the user will have to:
Register their device, and update the cert to and then rebuild.
- eas device:create
- eas credentials ---> review_pr-#
- re build
whusterj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR adds dynamic expo builds for PR's
When a PR is made we first run expo update to publish an expo-go version of the app, we do this first because expo-go updates are quick fast and this allows us to continue with our iterative process.
We then do two things, expo-build AND another expo-update. We do both because we know that expo-update does an OTA for the expo-build app in this way we can continually test that the two together are still working. Again, we do this separately so that we do not slow down the dev process, considering that expo-build is much slower.
In order to build the review app we also make a temporary change to the eas.json config, here we create a new entry in the config that dynamically creates a new channel with our PR number and a build profile for that build number. The reason we do not use the statically defined profile is that our builds are also tied to to channels, that means when we run this command we would be updating any other review app out there.
Checklist
How to test
Add user steps to achieve desired functionality for this feature.