Fixed wrong frequency (json) & upload for TTN V3

[itsygithub]

Workaround for wrong frequency in json file. Will also solve the problem with upload for TTN V3. Tested with 868 MHz.This is the first time ever I upload or commend in gitub. Hope I did it wright.

[d-a-v]

Nice finding !

Did you try to simply change from int to float in divisions ?
like:

doc["freq"] = "" + (freqs[gwayConfig.ch].upFreq / 1000000);

to

doc["freq"] = "" + (freqs[gwayConfig.ch].upFreq / 1000000.0);

?

[itsygithub]

Thank you for your fast answer. I tried your fix for both lines:

doc["freq"] = "" + (freqs[gwayConfig.ch].upFreq / 1000000.0);
ftoa((double)freqs[gwayConfig.ch].upFreq / 1000000.0, cfreq, 6);

But as example the frequency for channel 0 was 868099975 so it did not fix the issue.
Tested with Hallad-Board.

[d-a-v]

Thanks for trying !
I hope your fix will be merged and maybe the data structure improved by the author to avoid to repeat frequencies in both format.

[itsygithub]

Thanks a lot :-) It is really a great project and it should also live with stack V3 :-)

[dabredo]

Should be here 868.500?

[itsygithub]

What do you think has to be 868.500? Which value should be changed?

[d-a-v]

"868.800"?

[itsygithub]

Ah, now I see - typing error! I will correct it - thanks!

[dinoi7]

Thanks for this great project and thanks for this fix.
Unfortunately I still have problems to make downlink and OTAA working.
Could you please check or provide me your TTN Settings for the Node and for the Gateway:

Node:

Gateway:

In the OTAA case I try to trace it from TTN Cloud to 1ch Gateway to Node Serial Log.

In the TTN Cloud the Downlink is send to the gateway:

In the Gateway I can see the transfer:

But in the Node Serial log there is nothing arrived:

Any ideas?
Regards
Dinoi

[pimente]

@itsygithub
Replacing ftoa by dtostrf worked for me:

// ftoa((double)freqs[gwayConfig.ch].upFreq / 1000000, cfreq, 6);
dtostrf((double)freqs[gwayConfig.ch].upFreq / 1000000, 6, 3, cfreq);

and does not require to change loraModem.h. Maybe this could make your PR lighter?

[IoTThinks]

// ftoa((double)freqs[gwayConfig.ch].upFreq / 1000000, cfreq, 6);
dtostrf((double)freqs[gwayConfig.ch].upFreq / 1000000, 6, 3, cfreq);

This is working for me.
FYI, the fix is in _txRx.ino