Improve RSS feed image parsing

thingbomb · Sep 11, 2024 · 5cef493 · 5cef493
1 parent 1d08c21
commit 5cef493
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/css/home.css b/src/css/home.css
@@ -20,7 +20,7 @@ input,
 select,
 textarea,
 button {
-    font-family: InterVariable,ui-sans-serif,system-ui,-apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Helvetica Neue,Arial,Noto Sans,sans-serif,"Apple Color Emoji","Segoe UI Emoji",Segoe UI Symbol,"Noto Color Emoji";
+    font-family: InterVariable,ui-sans-serif,system-ui,-apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Helvetica Neue,Arial,Noto Sans,sans-serif,"Apple Color Emoji","Segoe UI Emoji",Segoe UI Symbol,"Noto Color Emoji",sans-serif;
 }
 
 h1,

diff --git a/src/js/home.js b/src/js/home.js
@@ -15,12 +15,15 @@ function cleanUpExpiredCache() {
 }
 
 function decodeHtmlEntities(str) {
-    return str
-        .replaceAll('&lt;', '<')
-        .replaceAll('&gt;', '>')
-        .replaceAll('&amp;', '&')
-        .replaceAll('&quot;', '"')
-        .replaceAll('&#39;', "'");
+    const entities = {
+        '&lt;': '<',
+        '&gt;': '>',
+        '&amp;': '&',
+        '&quot;': '"',
+        '&#39;': "'"
+    };
+
+    return str.replace(/&(lt|gt|amp|quot|#39);/g, (match, p1) => entities[match] || match);
 }
 
 function areDatesOnTheSameDay(date1, date2) {
@@ -84,7 +87,7 @@ function fetchFeed(url) {
                 let potentialImage;
                 if (content.innerHTML) {
                     placeholder.innerHTML = decodeHtmlEntities(content.innerHTML);
-                    potentialImage = (item.getElementsByTagName("media:thumbnail").src) || (placeholder.querySelector("img") ? placeholder.querySelector("img").src : `https://logo.clearbit.com/${url.split("/")[2]}`);
+                    potentialImage = (item.getElementsByTagName("media:thumbnail").src || item.getElementsByTagName("media:content")[0]?.getAttribute("url")) || (placeholder.querySelector("img") ? placeholder.querySelector("img").src : `https://logo.clearbit.com/${url.split("/")[2]}`);
                 } else {
                     placeholder.innerHTML = description ? description : new Date(item.querySelector("pubDate, published") ? item.querySelector("pubDate, published").textContent : "").toDateString();
                     potentialImage = item.getElementsByTagName("media:thumbnail")?.url || `https://logo.clearbit.com/${url.split("/")[2]}`;