-
Notifications
You must be signed in to change notification settings - Fork 70
feat: tedge flows statistics are published over MQTT #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: tedge flows statistics are published over MQTT #3843
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
404f0c1 to
6103e07
Compare
Robot Results
Failed Tests
|
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
| let service_config = FlowsMapperConfig { | ||
| statistics_topic: Topic::new(&format!("{te}/{service_id}/statistics"))?, | ||
| status_topic: Topic::new(&format!("{te}/{service_id}/status"))?, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now time to discuss the appropriate topics for flows status and statistics #3846 (comment)
I think that it would make sense to publish the statistics as measurements under {te}/{service_id}/m/statistics. But then these stats will be pushed by default to the cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah publishing under the standard thin-edge.io mqtt topic structure would be more consistent, but we might need to use a different telemetry endpoint to publish this information to avoid sending too much information to the cloud by default.
We could create a convention where some local/internal information which is meant for local/on-device consumption (rather than intended for the cloud):
{te}/{service_id}/local/statisticsAlternatively, we could use flows as the type since the flows statistics maybe published on serveral services in the future, e.g. tedge-mapper-c8y, tedge-mapper-az, tedge-flows etc.
{te}/{service_id}/flows/statisticsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new proposal for the topic would be:
{te}/{service_id}/status/metrics
Proposed changes
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments