Use Supervisord to manage processes #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into palworld-service
… into palworld-service
… into palworld-service
… into palworld-service
… into palworld-service
… into palworld-service
|
What's left to do on this? |
I didn't really had the time to continue with this. But I am currently struggling with the eventlistener. Since I have added another process (the player logging) the behavior is really strange. If the player logging is enabled it does not send the same events to see it you can add the line LogWarn "$header" >&2to the palworld_state_handler.sh before the if statement which checks the service name then if I enable the player logging in the docker compose file I get this output: and if it is disabled: But we should get both the events:
on shutdown there is a similar issue:
I don't know what I am doing wrong. I think the easiest way is to test it with webbooks. You can see it there very clearly. If that issue is resolved. The
|
… into palworld-service
|
@Luatan This solved it. diff --git a/services/listener/palworld_state_handler.sh b/services/listener/palworld_state_handler.sh
index b8b103a..c61d5bf 100644
--- a/services/listener/palworld_state_handler.sh
+++ b/services/listener/palworld_state_handler.sh
@@ -21,6 +21,12 @@ while true; do
printf "READY\n"
read -r header
parse_headers "$header"
+ LogWarn "${header}" >&2
+ if [ -n "${len}" ]; then
+ read -n "${len}" data
+ LogWarn "${data}" >&2
+ parse_headers "${data}"
+ fi
if [ "${processname}" = "palworld" ]; then
case $eventname inENABLE_PLAYER_LOGGING=true ENABLE_PLAYER_LOGGING=false |
|
Hey @MusclePr, thanks for helping. Still need to test it, but I was wondering if this feature is something that should still be implemented. I haven't had the time to really follow the progress of the container. And would like to get some feedback first, before I go ahead and invest more time into this. |
|
Hi @Luatan, I am still not really sure, I'll think about it and get back to you, sorry I was not able to check this out sooner. |
|
Deciding to close this issue. Supervisored is not the way I want to move forward with managing processes. Instead opening a feature request to handle the processes with s6 overlay |
I was actually also looking for alternatives, but couldn't find any. No clue how I didn't find s6 overlay. it looks promising as far as I have seen. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Choices
Processes Managed by Supervisord
Test instructions
Environment Variables
These Environment variables can be used for all test cases
Always Running Services
These services should always be running if enabled in the config
Test
docker exec -it palworld-server supervisorctl statusScripts
These scripts use supervisord to shutdown the server if necessary.
Restore Test
docker exec -it palworld-server restoreUpdate Test
docker exec palworld-server updateand verify that the server is up to datedocker exec palworld-server updateand verify that an update is foundAuto Reboot Test
docker exec palworld-server auto_reboot.shChecklist before requesting a review