fix(purge) prevent purging when using a custom LRU cache #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, calling `purge()` on an instance that has a custom LRU cache will also garbage collect said instance, and a new one created by `lrucache.new()` will take its place. As long as the new `flush_all()` method for LRU caches isn't supported (introduced in OpenResty 1.13.6.2), we shall be proactive about this limitation and prevent the use of `purge()`. This limitation is soon to be lifted for OpenResty >= 1.13.6.2 thanks to #78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, calling
purge()on an instance that has a custom LRUcache will also garbage collect said instance, and a new one created by
lrucache.new()will take its place.As long as the new
flush_all()method for LRU caches isn't supported(introduced in OpenResty 1.13.6.2), we shall be proactive about this
limitation and prevent the use of
purge().This limitation is soon to be lifted for OpenResty >= 1.13.6.2 thanks
to #78.