rockspec: use https instead of git #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using git:// for direct linking is not supported by github any more, so the rock is uninstallable on its current state. The simplest solution is changing the protocol from git:// to https:// A workaround exists - you can force git to always use https:// by using these settings: git config --global url."https://github.com/".insteadOf git@github.com: git config --global url."https://".insteadOf git:// But ideally the rocks should be installable without such global config changes.
thibaultcha
reviewed
Mar 29, 2023
| source = { | ||
| url = "git://github.com/thibaultcha/lua-cassandra", | ||
| url = "https://github.com/thibaultcha/lua-cassandra", |
There was a problem hiding this comment.
I think we have git+https as a better fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using git:// for direct linking is not supported by github any more, so the rock is uninstallable on its current state.
The simplest solution is changing the protocol from git:// to https://, and then push the new rockspec to luarocks.
A workaround exists - you can force git to always use https:// by using these settings:
git config --global url."https://github.com/".insteadOf git@github.com: git config --global url."https://".insteadOf git://
But ideally the rocks should be installable without such global config changes.