Merge pull request Shopify#350 from Shopify/fix-empty-markup-in-Space…

…InsideBraces Ignore empty `{{}}` in `SpaceInsideBraces`
thewrittentab · Jul 6, 2021 · 11ce290 · 11ce290
2 parents 14fef94 + f843c00
commit 11ce290
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/theme_check/checks/space_inside_braces.rb b/lib/theme_check/checks/space_inside_braces.rb
@@ -51,7 +51,7 @@ def after_tag(_node)
     end
 
     def on_variable(node)
-      return if @ignore
+      return if @ignore || node.markup.empty?
       if node.markup[0] != " "
         add_offense("Space missing after '{{'", node: node) do |corrector|
           corrector.insert_before(node, " ")

diff --git a/test/checks/space_inside_braces_test.rb b/test/checks/space_inside_braces_test.rb
@@ -293,4 +293,14 @@ def test_dont_report_missing_spaces_inside_strings
     )
     assert_offenses('', offenses)
   end
+
+  def test_dont_report_empty_variables
+    offenses = analyze_theme(
+      ThemeCheck::SpaceInsideBraces.new,
+      "templates/index.liquid" => <<~END,
+        {{}}
+      END
+    )
+    assert_offenses('', offenses)
+  end
 end