-
Notifications
You must be signed in to change notification settings - Fork 21
Add aliases to content pages #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: sandra <sadindi03@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the docsy theme being updated? This shouldn't happen if you're working from docsy
at HEAD.
Oh, it seems that you pushed directly to the docsy
branch in your local repo. You need to create a branch with another name in your local repo, otherwise you'll lose access to the upstream docsy
.
Please resubmit your PR, but do so from a local branch that has a name other than docsy
.
Overall this PR seems ok, though I'll review it in more detail after.
@chalin Makes sense. Is there any way I can reverse the update to the themes/docsy? It's now being tracked by all my branches. |
The problem isn't the Docsy theme commit -- the commit in this PR is the correct commit. The problem is that this PR is showing a Docsy theme commit as a change. This is likely happening because you created this PR based on the
The previous statement is important. Note that before you create the new branch, refresh your local
(I get the impression that you might have done this already, because #77 seems to be ok -- i.e., not showing an update to the |
@chalin Right i did use those commands. Like you mentioned, problem was making commits on my local docsy branch . I'll resubmit the PR. Thanks |
Closed by #78 |
Added aliases to content pages to cover issue Dindihub/docsy-tuf.io#14
Please review @chalin