Skip to content

Conversation

@erickt
Copy link
Collaborator

@erickt erickt commented Jan 9, 2019

The fuchsia build system does not use cargo to build libraries, and at
the moment it is unable to convey environment variables. As a stopgap,
this removes the use of env!("CARGO_PKG_VERSION") until we can add
support for this.

Copy link
Contributor

@heartsucker heartsucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fair change to make for now. I'm opening a ticket to revert it down the road.

@heartsucker
Copy link
Contributor

Hmm I think you might need to rebase on develop here. I'm downloading nightly 1.33.0 now to test.

@heartsucker
Copy link
Contributor

I can't compile this locally either.

heartsucker@pythagoras:~/code/heartsucker/rust-tuf (pr/170)$ rustc --version
rustc 1.33.0-nightly (09d6ab90e 2018-12-20)
heartsucker@pythagoras:~/code/heartsucker/rust-tuf (pr/170)$ cargo --version
cargo 1.33.0-nightly (2cf1f5dda 2018-12-11)

A small sample of the errors I'm getting.

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
 --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/mod.rs:4:5
  |
4 | use core::pin::Pin;
  |     ^^^^^^^^^^^^^^
  |
  = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
 --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:4:27
  |
4 |     marker::{PhantomData, Unpin},
  |                           ^^^^^
  |
  = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
 --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:5:5
  |
5 |     pin::Pin,
  |     ^^^^^^^^
  |
  = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
  --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:22:13
   |
22 | impl<'a, T> Unpin for LocalFutureObj<'a, T> {}
   |             ^^^^^
   |
   = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
  --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:92:13
   |
92 | impl<'a, T> Unpin for FutureObj<'a, T> {}
   |             ^^^^^
   |
   = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
   --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:157:29
    |
157 |     F: Future<Output = T> + Unpin + 'a
    |                             ^^^^^
    |
    = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
   --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:171:50
    |
171 | unsafe impl<'a, T, F> UnsafeFutureObj<'a, T> for Pin<&'a mut F>
    |                                                  ^^^^^^^^^^^^^^
    |
    = help: add #![feature(pin)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'pin' (see issue #49150)
   --> /home/heartsucker/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.11/src/future/future_obj.rs:211:54
    |
211 |     unsafe impl<'a, T, F> UnsafeFutureObj<'a, T> for Pin<Box<F>>
    |                                                      ^^^^^^^^^^^
    |
    = help: add #![feature(pin)] to the crate attributes to enable

How did you compile this?

The fuchsia build system does not use cargo to build libraries, and at
the moment it is unable to convey environment variables. As a stopgap,
this removes the use of `env!("CARGO_PKG_VERSION")` until we can add
support for this.

Change-Id: If35a244533c95ba2a7bedff2c45b5d33d7a3a84b
@erickt
Copy link
Collaborator Author

erickt commented Jan 10, 2019

Just pushed up a new version. And I think your rustc is a little old. I'm using rustc 1.33.0-nightly (8e2063d02 2019-01-07) for this.

Change-Id: I227a16fc576ecc84f2a72635a1395601c5730c7f
@erickt
Copy link
Collaborator Author

erickt commented Jan 10, 2019

Drat, nightly-2019-01-10 is busted, I included a patch to temporarily pin CI to nightly-2019-01-09.

@heartsucker heartsucker merged commit d2e8f5c into theupdateframework:develop Jan 10, 2019
@erickt
Copy link
Collaborator Author

erickt commented Jan 10, 2019

thanks @heartsucker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants