-
Notifications
You must be signed in to change notification settings - Fork 35
Don't include the version of rust-tuf in the user agent #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
heartsucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a fair change to make for now. I'm opening a ticket to revert it down the road.
|
Hmm I think you might need to rebase on |
|
I can't compile this locally either. A small sample of the errors I'm getting. How did you compile this? |
The fuchsia build system does not use cargo to build libraries, and at
the moment it is unable to convey environment variables. As a stopgap,
this removes the use of `env!("CARGO_PKG_VERSION")` until we can add
support for this.
Change-Id: If35a244533c95ba2a7bedff2c45b5d33d7a3a84b
|
Just pushed up a new version. And I think your rustc is a little old. I'm using |
Change-Id: I227a16fc576ecc84f2a72635a1395601c5730c7f
|
Drat, |
|
thanks @heartsucker! |
The fuchsia build system does not use cargo to build libraries, and at
the moment it is unable to convey environment variables. As a stopgap,
this removes the use of
env!("CARGO_PKG_VERSION")until we can addsupport for this.