Merged
Conversation
Signed-off-by: Justin Cappos <justincappos@gmail.com>
lukpueh
approved these changes
Oct 17, 2019
Member
lukpueh
left a comment
lukpueh
left a comment
There was a problem hiding this comment.
LGTM. Note that tests keeps failing on Python 2.7 on Windows (see AppVeyor checks). I have to troubleshoot this, but I suggest to merge this PR independently as it has no effect on the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Cappos justincappos@gmail.com
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #:
Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following
requirements: