Skip to content

Bump version 0.12.0#921

Merged
JustinCappos merged 2 commits intotheupdateframework:developfrom
lukpueh:bump_version_0.12.0-dev0
Oct 14, 2019
Merged

Bump version 0.12.0#921
JustinCappos merged 2 commits intotheupdateframework:developfrom
lukpueh:bump_version_0.12.0-dev0

Conversation

@lukpueh
Copy link
Member

@lukpueh lukpueh commented Sep 20, 2019 •
edited
Loading

TODO

  1. Wait for securesystemslib 0.12.0 to be released on PyPI
  2. Merge Explicitly encode data passed to securesystemslib.keys #917 and Remove uses of securesystemslib.util.TempFile #918 to adapt to breaking changes in securesystemslib
  3. Rebase this release PR onto develop
  4. Release tuf 0.12.0-dev0
    Alternatively, and if preferred, release as 1.0.0-dev0 instead (requires changing the version numbers in CHANGELOG.md, setup.py and __init__.py)

@trishankatdatadog trishankatdatadog added this to the 0.12.0 milestone Oct 2, 2019
@lukpueh
Copy link
Member Author

lukpueh commented Oct 3, 2019

Update:
The TUF team has decided that the next release will be 0.12.0 (w/o dev suffix), under the condition that we add a disclaimer about TUF's currently limited protection against slow retrieval attacks. See #928 for a proposal. (cc @trishankatdatadog, @JustinCappos @mnm678 )

@JustinCappos JustinCappos marked this pull request as ready for review October 3, 2019 12:13
JustinCappos
JustinCappos reviewed Oct 3, 2019
View reviewed changes
setup.py Outdated
setup(
name = 'tuf',
version = '0.11.2.dev3', # If updating version, also update it in tuf/__init__.py
version = '0.12.0-dev0', # If updating version, also update it in tuf/__init__.py
Copy link
Member

@JustinCappos JustinCappos Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = '0.12.0-dev0', # If updating version, also update it in tuf/__init__.py
version = '0.12.0', # If updating version, also update it in tuf/__init__.py

JustinCappos
JustinCappos requested changes Oct 3, 2019
View reviewed changes
Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change these version strings, right?

tuf/__init__.py Outdated
# Currently, when the version is changed, it must be set in both locations.
# TODO: Single-source the version number.
__version__ = "0.11.2.dev3"
__version__ = "0.12.0-dev0"
Copy link
Member

@JustinCappos JustinCappos Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = "0.12.0-dev0"
__version__ = "0.12.0"

@lukpueh
Copy link
Member Author

lukpueh commented Oct 3, 2019

@JustinCappos, yes absolutely. Thanks for the reminder! I would have done it, when rebasing to integrate a merged #928.

lukpueh
lukpueh commented Oct 3, 2019
View reviewed changes
docs/CHANGELOG.md Outdated
# Changelog


## v0.12.0-dev0
Copy link
Member Author

@lukpueh lukpueh Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove -dev0

@lukpueh
Copy link
Member Author

lukpueh commented Oct 3, 2019

@trishankatdatadog wants to get #885 in before we bump to 0.12.0. #885 is already finished and reviewed. All that's missing is a test.

@trishankatdatadog trishankatdatadog changed the title Bump version 0.12.0-dev0 Bump version 0.12.0 Oct 3, 2019
@lukpueh lukpueh mentioned this pull request Oct 10, 2019
Merged
3 tasks
@lukpueh lukpueh force-pushed the bump_version_0.12.0-dev0 branch from 4385ea2 to 37a6b12 Compare October 14, 2019 14:34
Lukas Puehringer added 2 commits October 14, 2019 16:47
CHANGELOG: Add 0.12.0 entry
3b77a7d 
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
setup.py/__init__.py: bump version to v0.12.0
9a8e3c9 
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh lukpueh force-pushed the bump_version_0.12.0-dev0 branch from 37a6b12 to 9a8e3c9 Compare October 14, 2019 14:47
@lukpueh lukpueh requested a review from JustinCappos October 14, 2019 16:22
JustinCappos
JustinCappos approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trishankatdatadog
trishankatdatadog approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, @lukpueh is the man

@JustinCappos JustinCappos merged commit 6138395 into theupdateframework:develop Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustinCappos JustinCappos JustinCappos approved these changes

+1 more reviewer

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lukpueh @JustinCappos @trishankatdatadog