Merged
Conversation
Member
Author
lukpueh
reviewed
Mar 11, 2025
Member
lukpueh
left a comment
lukpueh
left a comment
There was a problem hiding this comment.
Great work! I only skimmed through the related PRs but everything looks well tested and has been reviewed, so I'm happy to approve after the conflict is resolved.
docs/CHANGELOG.md
Outdated
| * ngclient: TLS certificate source was changed. Certificates now come from operating | ||
| system certificate store instead of `certifi` (#2762) | ||
| * ngclient: The updater can now initialize from embedded initial root metadata every | ||
| time. Users are recommended to provide the `bootstrap` argument to Updater. |
Member
There was a problem hiding this comment.
Suggested change
| time. Users are recommended to provide the `bootstrap` argument to Updater. | |
| time. Users are recommended to provide the `bootstrap` argument to Updater. (#2767) |
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
lukpueh
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suppose this is ready.
Fixes #2796