Query() caching with stale-while-revalidate (TanStack Query style): avoid loaders on every return visit #746

Activity

1. vishxrad

   added

   enhancementNew feature or requestNew feature or request

   on Jul 9, 2026
2. iambharathpadhu commented on Jul 9, 2026

   

   iambharathpadhu

   on Jul 9, 2026

   Contributor

   More actions

   Hey — I'd love to take this on. Poked around the runtime to find where the return-visit spinner actually comes from, and I think it answers your "runtime cache vs toolProvider middleware" question.

   Short version: a toolProvider wrapper gets you dedup and background-revalidation for free — but it won't kill the spinner on its own. That placeholder isn't a transport thing. The QueryManager's cache is per-mount, so on a real remount it's rebuilt empty and loading flips true before callTool is even awaited — even a synchronous cache hit flashes the loader for a tick. To render cached-then-revalidate instantly, the manager has to already hold the value at mount time.

   So the piece that's actually missing is a cache that outlives a mount. Two ways I can see:

   1. Make the cache injectable (createQueryManager(toolProvider, cache?)) and hang it off a QueryClient-style context in react-lang.
   2. Hoist the QueryManager above the Renderer so its cache survives unmount/remount.

   Neither touches OpenUI Lang or the parser. I lean (1) — it's small and additive (dispose() already keeps the cache today), and a QueryClient-style provider gives a natural home for stale-time, tag-invalidation, and opt-in persistence down the line.

   If that direction sounds right, I'd keep the first PR tight — injectable cache + stale-while-revalidate + stale-time + in-flight dedup, tested at the queryManager level — and leave invalidation/persistence/optimistic updates as follow-ups. Mostly just want your call on (1) vs (2) before I start. Thanks!
3. abhithesys commented on Jul 13, 2026

   

   abhithesys

   on Jul 13, 2026

   Contributor

   More actions

   You can get most of this today in userland, since toolProvider is just a map of async functions — wrap each read tool with queryClient.fetchQuery so calls go through TanStack Query's cache:

   import { QueryClient } from '@tanstack/react-query';
   
   const queryClient = new QueryClient();
   
   const toolProvider = {
     list_tickets: (args) =>
       queryClient.fetchQuery({
         queryKey: ['list_tickets', args],
         queryFn: () => fetch('/api/tickets').then(r => r.json()),
         staleTime: 30_000, // repeat visits within 30s resolve from cache, no spinner
       }),
   
     // write tools stay unwrapped — never cache mutations
     create_ticket: (args) =>
       fetch('/api/tickets', { method: 'POST', body: JSON.stringify(args) }).then(r => r.json()),
   };
   
   <Renderer toolProvider={toolProvider} response={code} library={library} />
4. abhithesys

   added

   questionFurther information is requestedFurther information is requested

   and removed

   enhancementNew feature or requestNew feature or request

   on Jul 14, 2026