refactor(MiniCharts): Simplify data handling in MiniAreaChart and MiniLineChart components #166
+10
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ankit-thesys
commented
Jul 25, 2025
ankit-thesys
commented
- Removed the getRecentDataThatFits utility function to streamline data processing.
- Updated MiniAreaChart and MiniLineChart to directly transform the full data set for chart rendering, enhancing clarity and reducing complexity.
- Adjusted related comments for improved understanding of data transformation logic.
…iLineChart components - Removed the getRecentDataThatFits utility function to streamline data processing. - Updated MiniAreaChart and MiniLineChart to directly transform the full data set for chart rendering, enhancing clarity and reducing complexity. - Adjusted related comments for improved understanding of data transformation logic.
…t and MiniLineChart components - Eliminated containerRef and related state management for container width in both MiniAreaChart and MiniLineChart components. - Simplified imports by removing useEffect and useState, enhancing component clarity and performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.