-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology2: add support for rt721-sdw topology #9524
base: main
Are you sure you want to change the base?
Conversation
"cavs-sdw\;sof-ptl-rt721\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ | ||
SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it assume PCH DMIC is used? So that your HDMI IDs are 7, 8, and 9. If so, you have to append -4ch
or -2ch
to the topology name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.. per suggestion.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think HDMI IDs will be 5, 6, 7 which are the default of HDMI1_D, HDMI2_ID and HDMI3_ID. IOW, we don't need HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9
for the with SDW-DMIC version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, have updated accordingly.
04252f6
to
fe82a75
Compare
@bardliao good for you now ? |
No, @naveen-manohar please remove |
fe82a75
to
424a625
Compare
Adding topology support for rt721-sdw monolithic codec verified on ptl-rvp, with configuration: 1. sof-ptl-rt721: uses SDW-DMIC 2. sof-ptl-rt721-4ch: uses PCH-DMIC Signed-off-by: Naveen Manohar <naveen.m@intel.com>
424a625
to
daf2b5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Adding topology support for rt721-sdw monolithic codec
Verified on PTL-RVP