-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Topology2: Add beamformer and DRC to HDA analog capture #9447
Tools: Topology2: Add beamformer and DRC to HDA analog capture #9447
Conversation
Note: The Jenkins CI passes because there is no test for sof-hda-generic.tplg without DMIC. I'll add the enums remove patch to this as well to be similar as tplg with DMIC and avoid the issue to show up with new RVP config. |
The topologies built with cavs-es83x6.conf (sof-mtl-es83x6-ssp1-hdmi-ssp02.tplg and sof-mtl-hdmi-ssp02) are not using dai-copier-eqiir-module-copier-capture pipeline, so this include can be deleted. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The pipeline is generic for any type of DAI, so using DMIC0_DAI_EQIIR to select IIR blob is wrong. The blob definition need to be done at upper level where endpoint is known. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch changes in cavs-mixin-mixout-hda based topologies the analog capture pipeline from dai-copier -> eqiir -> host-copier to dai-copier -> eqiir -> module-copier -> host-copier It allows more flexibility with processing add into host-copier pipeline and allow capture stream duplication to multiple PCMs. This change adds 2.2 MCPS from module-copier in TGL platform. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to analog microphone capture pipeline TDFB beamformer and DRC for dynamic range control. The enhanced host copier pipeline is enabled if HDA_MIC_ENHANCED_CAPTURE is set to true in topologies build. The keys EFX_HDA_MIC_TDFB_PARAMS and EFX_HDA_MIC_DRC_PARAMS control the applied configurations blobs. There is no processing applied to capture audio since the topology is built with pass-through blobs. E.g. UCM2 should set up processing with blobs those have effect. The change impacts sof-hda-generic.tplg. The other topologies with DMIC are kept as before without added processing. The analog capture pipelines are before this change: dai-copier -> eqiir -> module-copier -> host-copier After: dai-copier -> eqiir -> module-copier -> TDFB -> DRC -> host-copier Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
3f7dfa1
to
112617b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @singalsu ! Had to ponder a while why only for sof-hda-generic, but yes. I think this makes sense.
SOFCI TEST |
No description provided.