Tools: Topology2: Add beamformer and DRC to HDA analog capture #9447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The topology sof-hda-generic.tplg is before changes:
After add of module-copier, impacts all hda-generic:
After add of TDFB and DRC into sof-hda-generic.tplg:
|
|
Note: The Jenkins CI passes because there is no test for sof-hda-generic.tplg without DMIC. I'll add the enums remove patch to this as well to be similar as tplg with DMIC and avoid the issue to show up with new RVP config. |
lgirdwood
approved these changes
Sep 9, 2024
The topologies built with cavs-es83x6.conf (sof-mtl-es83x6-ssp1-hdmi-ssp02.tplg and sof-mtl-hdmi-ssp02) are not using dai-copier-eqiir-module-copier-capture pipeline, so this include can be deleted. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The pipeline is generic for any type of DAI, so using DMIC0_DAI_EQIIR to select IIR blob is wrong. The blob definition need to be done at upper level where endpoint is known. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch changes in cavs-mixin-mixout-hda based topologies the analog capture pipeline from dai-copier -> eqiir -> host-copier to dai-copier -> eqiir -> module-copier -> host-copier It allows more flexibility with processing add into host-copier pipeline and allow capture stream duplication to multiple PCMs. This change adds 2.2 MCPS from module-copier in TGL platform. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to analog microphone capture pipeline TDFB beamformer and DRC for dynamic range control. The enhanced host copier pipeline is enabled if HDA_MIC_ENHANCED_CAPTURE is set to true in topologies build. The keys EFX_HDA_MIC_TDFB_PARAMS and EFX_HDA_MIC_DRC_PARAMS control the applied configurations blobs. There is no processing applied to capture audio since the topology is built with pass-through blobs. E.g. UCM2 should set up processing with blobs those have effect. The change impacts sof-hda-generic.tplg. The other topologies with DMIC are kept as before without added processing. The analog capture pipelines are before this change: dai-copier -> eqiir -> module-copier -> host-copier After: dai-copier -> eqiir -> module-copier -> TDFB -> DRC -> host-copier Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
hda_generic_amic_add_preprocess
branch
from
3f7dfa1
to
112617b
Compare
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.