Audio: MFCC: Fix mistake with HiFi4 circular buffer index #9415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction AE_L16_XC() uses circular buffer0, so the buffer setup instruction need to be changed. The proper instruction for buffer 1 would have been AE_L16_XC1(). Due to this error the MFCC output became incorrect after wrong circular buffer wrap. Fixes: 5c92bdd ("Audio: MFCC: Add HiFi4 implementation of MFCC") Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Only cosmetic change, no functionality changed. Noticed while comparing hifi3 and hifi4 code versions. Now one difference less. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Sep 2, 2024
kv2019i
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.