Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Test: Audio: Mitigate trace flood in process_test.m #9403

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Tools: Test: Audio: Mitigate trace flood in process_test.m #9403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tools/test/audio/comp_run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,14 @@ run_testbench ()
# shellcheck disable=SC2086
$VALGRIND_CMD $CMD
else
# shellcheck disable=SC2086
$VALGRIND_CMD $CMD 2> "$FN_TRACE"
$VALGRIND_CMD $CMD 2> "$FN_TRACE" || {
local ret=$?
echo ----------------------------------------------------------
cat "$FN_TRACE"
echo ----------------------------------------------------------
return $ret # "exit" would be for something unexpected and catastrophic,
# not for a "regular" test failure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments were for you, not for the final version :-) A bit verbose now but OK

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it fits there :)

}
fi
}

Expand Down
3 changes: 2 additions & 1 deletion tools/test/audio/process_test.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,12 +411,13 @@
test.fr_rp_max_db = 0.5; % Allow 0.5 dB frequency response ripple

% No need to collect trace
test.trace = '';
test.trace = [tempname('/tmp') '.txt'];
end

function test = test_run_process(test)
delete_check(1, test.fn_out);
test = test_run(test);
delete_check(1, test.trace);
end

function test_result_print(t, testverbose, testacronym, test)
Expand Down
Loading