Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/prj.conf: disable PICOLIBC with CONFIG_MINIMAL_LIBC=y #8255

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Sep 23, 2023

Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by default.

PICOLIBC does not seem compatible with sparse yet: zephyrproject-rtos/zephyr#63003

Even if it were compatible with sparse, it seems like a pretty big change that we should not immediately and blindly accept.

Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by
default.

PICOLIBC does not seem compatible with sparse yet:
zephyrproject-rtos/zephyr#63003

Even if it were compatible with sparse, it seems like a pretty big
change that we should not immediately and blindly accept.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 23, 2023

The fix for the unrelated build-windows failures is in:

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 25, 2023

Excellent debug @marc-hb on the sparse problem. On one hand, now would be a good time to change to picolibc (as we are very early in 2.8 cycle), but agreed, we need to solve the sparse issue first (and not block other Zephyr updated due to this).

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 25, 2023

@wszypelt ok to merge despite failures? this is gating Zephyr updates now and this PR alone does not have any change to build -- it explicitly sets an option that newer Zephyr versions would change to something else by default.

@wszypelt
Copy link

@kv2019i We had a problem with the network on the machines, the LAB team has already fixed it, correct results should be available within an hour

@tmleman
Copy link
Contributor

tmleman commented Sep 25, 2023

@kv2019i I think we can merge it

@kv2019i kv2019i merged commit 2a9473a into thesofproject:main Sep 25, 2023
38 of 47 checks passed
@marc-hb marc-hb deleted the disable-picolibc branch September 26, 2023 18:05
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 26, 2023

Actually we can make this workaround more sparse-specific, not sure why I didn't think about that earlier. Please review small follow-up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants