-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app/prj.conf: disable PICOLIBC with CONFIG_MINIMAL_LIBC=y #8255
Conversation
Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by default. PICOLIBC does not seem compatible with sparse yet: zephyrproject-rtos/zephyr#63003 Even if it were compatible with sparse, it seems like a pretty big change that we should not immediately and blindly accept. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
The fix for the unrelated build-windows failures is in: |
Excellent debug @marc-hb on the sparse problem. On one hand, now would be a good time to change to picolibc (as we are very early in 2.8 cycle), but agreed, we need to solve the sparse issue first (and not block other Zephyr updated due to this). |
@wszypelt ok to merge despite failures? this is gating Zephyr updates now and this PR alone does not have any change to build -- it explicitly sets an option that newer Zephyr versions would change to something else by default. |
@kv2019i We had a problem with the network on the machines, the LAB team has already fixed it, correct results should be available within an hour |
@kv2019i I think we can merge it |
Actually we can make this workaround more sparse-specific, not sure why I didn't think about that earlier. Please review small follow-up: |
Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by default.
PICOLIBC does not seem compatible with sparse yet: zephyrproject-rtos/zephyr#63003
Even if it were compatible with sparse, it seems like a pretty big change that we should not immediately and blindly accept.