-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipc4: fixes for waiting. #8000
ipc4: fixes for waiting. #8000
Conversation
Give more context for pipeline context changes. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
No need to check every 250uS for ipc completion, relax this to avoid any busy scheduling. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
reset the atomic ipc4 message delay state after any timeout error. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
8231d2f
to
664b94b
Compare
Rebased on top of vmh fixes. |
@lgirdwood False positive, good to merge :) |
Some blob not found errors in CI results. Rerun. |
SOFCI TEST |
@@ -277,6 +282,8 @@ int set_pipeline_state(struct ipc_comp_dev *ppl_icd, uint32_t cmd, | |||
return 0; | |||
case COMP_STATE_ACTIVE: | |||
case COMP_STATE_PAUSED: | |||
tr_dbg(&ipc_tr, "ipc4: set pipeline %d new cmd state %x: pause from reset", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write active/pause from reset since there's a fallback case, but that's a nit-pick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, the state changes confused me a bit here. It probably needs more inline commentry from an IPC4 expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that it can fix #7774.
Some minor imrpovements and fixes.