ipc4: fixes for waiting. #8000
Merged
ipc4: fixes for waiting. #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
requested review from
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
btian1
reviewed
Aug 2, 2023
Give more context for pipeline context changes. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
No need to check every 250uS for ipc completion, relax this to avoid any busy scheduling. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
reset the atomic ipc4 message delay state after any timeout error. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
force-pushed
the
lrg/topic/ipc4-fixes
branch
from
8231d2f
to
664b94b
Compare
|
Rebased on top of vmh fixes. |
btian1
approved these changes
Aug 2, 2023
@lgirdwood False positive, good to merge :) |
juimonen
approved these changes
Aug 2, 2023
jsarha
approved these changes
Aug 2, 2023
|
Some blob not found errors in CI results. Rerun. |
|
SOFCI TEST |
plbossart
approved these changes
Aug 2, 2023
| @@ -277,6 +282,8 @@ int set_pipeline_state(struct ipc_comp_dev *ppl_icd, uint32_t cmd, | |||
| return 0; | |||
| case COMP_STATE_ACTIVE: | |||
| case COMP_STATE_PAUSED: | |||
| tr_dbg(&ipc_tr, "ipc4: set pipeline %d new cmd state %x: pause from reset", | |||
There was a problem hiding this comment.
I would write active/pause from reset since there's a fallback case, but that's a nit-pick
There was a problem hiding this comment.
tbh, the state changes confused me a bit here. It probably needs more inline commentry from an IPC4 expert.
keqiaozhang
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor imrpovements and fixes.