-
Notifications
You must be signed in to change notification settings - Fork 347
Audio: Mixer: Add hifi version processing functions for mixer #6134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bbf9476 to
c6a9f5c
Compare
|
SOFCI_TEST |
|
SOFCI TEST |
ShriramShastry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add check for __Pragma("no unroll"), __Pragma("no reorder"), and __Pragma("no simd") in the for loop?
Why ? |
It appears to aid optimization by providing additional information to the compiler. [ From HiFi User Guide documentation ] Pragma is widely used in Nature DSP Library functions. |
That's correct, but in this case @andrula-song is hand writing the intrinsics and the loops are complex. The autovectorizer works best on simple small loops, and the pragma suggestions above are not applicable here (and would probably make performance worse). |
singalsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great HiFi optimization work! Some small issues only:
|
approval condition to addressing comments from @singalsu of course |
|
hi @wszypelt , can you help to check internel CI? Thanks. |
|
@lrudyX can you check CI, its showing a blank page. Thanks ! |
|
SOFCI_TEST |
Add hifi3 & hifi4 version implementation of mixer processing functions. The hifi version functions can save at least 47% cycles than C version. Signed-off-by: Andrula Song <xiaoyuan.song@intel.com>

Add hifi3 & hifi4 version implementation of mixer processing functions.
The hifi version functions can save at least 47% cycles than C version.
Signed-off-by: Andrula Song xiaoyuan.song@intel.com